case statement in Scripting

Created on: May 11, 2014, 09:16:33 am

Ege115
Community Scripter
517 Posts
161 Respect +1

I am just playing around with the "case" statement. I have not used this statement before so this is my first time. And I found this statement really useful.

Anyway, I am using this script which has a case statement.

Code Snippet

Plaintext

main
{
place1 = getEnt("place1","targetname");
place1 thread place_weapons("m9");
}

place_weapons(weap)
{
ice_model = GetEnt("ice_model","targetname"); 

while(1)
{
while(isDefined(self))
	{
		players = get_players();
		for (i = 0; i < players.size; i++)
		{
		ice_model hide();
		self waittill("trigger", player);
 
		currentWeapon = players[i] GetCurrentWeapon();
		if(currentWeapon == weap)
		{
			self trigger_off();

			level.times_placed++;

			if(level.times_placed == 1)
			{
				case "m9":
				players[i] takeweapon("m9");
				ice_model show();
				ice_model setmodel("zombie_3rd_perk_bottle_doubletap");
				self waittill("trigger", player);
				players[i] giveweapon("m9_upgraded");
				ice_model hide();
				self trigger_on();
				break;
                                }
                    }
          }
}
}
}

But when I am loading my map, I get a script compile error saying, "illegal case statement". What did I do wrong with the case statement?

Thanks in advance.

Last Edit: May 11, 2014, 09:25:55 am by Ege115

This topic contains a post which is marked as the Best Answer. Click here to view it.

Reply #1 on: May 11, 2014, 09:52:01 am

YaPh1l
Community Scripter Elite
277 Posts
112 Respect +1

case statements are only allowed within a switch block.

- Phil.

Reply #2 on: May 11, 2014, 10:17:14 am

Ege115
Community Scripter
517 Posts
161 Respect +1

Quote from: YaPh1l on May 11, 2014, 09:52:01 am

case statements are only allowed within a switch block.

- Phil.

Uhm, a what? So what exactly is it I need to change at the case statement?

Reply #3 on: May 11, 2014, 02:05:36 pm

daedra descent
Community Daedra
2,789 Posts
244 Respect +1

Like this:

Code Snippet

Plaintext

main
{
place1 = getEnt("place1","targetname");
place1 thread place_weapons("m9");
}

place_weapons(weap)
{
ice_model = GetEnt("ice_model","targetname"); 

while(1)
{
while(isDefined(self))
	{
		players = get_players();
		for (i = 0; i < players.size; i++)
		{
		ice_model hide();
		self waittill("trigger", player);
 
		currentWeapon = players[i] GetCurrentWeapon();
		if(currentWeapon == weap)
		{
			self trigger_off();

			level.times_placed++;

			if(level.times_placed == 1)
			{
				switch(currentweapon)
				{
					case "m9":
					players[i] takeweapon("m9");
					ice_model show();
					ice_model setmodel("zombie_3rd_perk_bottle_doubletap");
					self waittill("trigger", player);
					players[i] giveweapon("m9_upgraded");
					ice_model hide();
					self trigger_on();
					break;
                               	}
			}
                    }
          }
}
}
}

EDIT: Really i'd just suggest an if statement instead of a case statement for what your trying to do. Case statements are primarily used as a way to return values, not do lengthy code.

Last Edit: May 11, 2014, 02:10:19 pm by daedra descent

Reply #4 on: May 11, 2014, 03:38:40 pm

Ege115
Community Scripter
517 Posts
161 Respect +1

Quote from: daedra descent on May 11, 2014, 02:05:36 pm

Like this:

Code Snippet

Plaintext

main
{
place1 = getEnt("place1","targetname");
place1 thread place_weapons("m9");
}

place_weapons(weap)
{
ice_model = GetEnt("ice_model","targetname"); 

while(1)
{
while(isDefined(self))
	{
		players = get_players();
		for (i = 0; i < players.size; i++)
		{
		ice_model hide();
		self waittill("trigger", player);
 
		currentWeapon = players[i] GetCurrentWeapon();
		if(currentWeapon == weap)
		{
			self trigger_off();

			level.times_placed++;

			if(level.times_placed == 1)
			{
				switch(currentweapon)
				{
					case "m9":
					players[i] takeweapon("m9");
					ice_model show();
					ice_model setmodel("zombie_3rd_perk_bottle_doubletap");
					self waittill("trigger", player);
					players[i] giveweapon("m9_upgraded");
					ice_model hide();
					self trigger_on();
					break;
                               	}
			}
                    }
          }
}
}
}

EDIT: Really i'd just suggest an if statement instead of a case statement for what your trying to do. Case statements are primarily used as a way to return values, not do lengthy code.

Okey thank you, that seems to have fixed it. Now an another error pops up. The script compile error is saying,
"missing case statement"
And developer 1 says that it is something regarding those first three lines you often have in scripts.

Code Snippet

Plaintext

#include, etc

Is it an another file I need to include there? If so which one?

Reply #5 on: May 11, 2014, 04:43:31 pm

PROxFTW
Community Scripter
214 Posts
82 Respect +1

No, nothing wrong with that more than likely. But make sure you add a default case statement. Most likely why that is happening is there is a value being returned that is not listed down.

Last Edit: May 11, 2014, 04:44:11 pm by PROxFTW

Reply #6 on: May 11, 2014, 05:47:13 pm

n123q45
Deleted Member

this is how a case statement is setup

Code Snippet

Plaintext

var = undefined; //the variable has to be set before the actual script

switch(var){ // var is the variable
  case "1": // what the first option the variable could be

  break; // how to end a case
  
  case "2": // what the second option the variable could be

  break;
}

this is used instead of lots of if else statements. you use this when the variable is set before this script. I used undefined to show that it has to be set before.

Reply #7 on: May 11, 2014, 06:01:40 pm

Ege115
Community Scripter
517 Posts
161 Respect +1

Quote from: PROxFTW on May 11, 2014, 04:43:31 pm

No, nothing wrong with that more than likely. But make sure you add a default case statement. Most likely why that is happening is there is a value being returned that is not listed down.

Hmm, well I still don't know exactly what I need to do, what value?

I'm a noob.

Last Edit: May 11, 2014, 06:05:16 pm by Ege115

Reply #8 on: May 11, 2014, 06:05:35 pm

YaPh1l
Community Scripter Elite
277 Posts
112 Respect +1

The value of the variable you "switch over". Although that shouldn't be causing any problems, it just wouldn't execute any case at all.

- Phil.

Reply #9 on: May 11, 2014, 06:17:51 pm

Ege115
Community Scripter
517 Posts
161 Respect +1

Well, then I have no idea what's wrong. I don't know how I should correct the script myself. D: I can't see anything wrong with it.

Reply #10 on: May 11, 2014, 06:22:00 pm

Quote from: Ege115 on May 11, 2014, 06:17:51 pm

Well, then I have no idea what's wrong. I don't know how I should correct the script myself. D: I can't see anything wrong with it.

Like said, it 'switches' to the value returned and executes the code. Let's say you have the case for 'm9' and 'thompson'. If you carry any other gun, presumably it'd pop out an error or do nothing. If it IS popping out an error, you have to add a default case so that if it isn't one of the listed guns it's execute the code in the default case.

C# Switch Example (Top box)

Last Edit: May 11, 2014, 06:22:38 pm by mrpeanut188

Reply #11 on: May 11, 2014, 06:50:14 pm

Ege115
Community Scripter
517 Posts
161 Respect +1

Quote from: mrpeanut188 on May 11, 2014, 06:22:00 pm

Like said, it 'switches' to the value returned and executes the code. Let's say you have the case for 'm9' and 'thompson'. If you carry any other gun, presumably it'd pop out an error or do nothing. If it IS popping out an error, you have to add a default case so that if it isn't one of the listed guns it's execute the code in the default case.

C# Switch Example (Top box)

Yay, I added this,

Code Snippet

Plaintext

default:

And the map loads without errors now. But when I hit the triggers, it doesn't take the weapon. (m9)

Here is the updated script if you wan tto see that.

Code Snippet

Plaintext

main
{
place1 = getEnt("place1","targetname");
place1 thread place_weapons("m9");
}

place_weapons(weap)
{
ice_model = GetEnt("ice_model","targetname"); 

while(1)
{
while(isDefined(self))
	{
		players = get_players();
		for (i = 0; i < players.size; i++)
		{
		ice_model hide();
		self waittill("trigger", player);
 
		currentWeapon = players[i] GetCurrentWeapon();
		if(currentWeapon == weap)
		{
			self trigger_off();

			level.times_placed++;

			if(level.times_placed == 1)
			{
				switch(currentweapon)
				{
					case "m9":
					players[i] takeweapon("m9");
					ice_model show();
					ice_model setmodel("zombie_3rd_perk_bottle_doubletap");
					self waittill("trigger", player);
					players[i] giveweapon("m9_upgraded");
					ice_model hide();
					self trigger_on();
					break;
                                        default:
                               	}
			}
                    }
          }
}
}
}

Thanks for the help so far, I am getting closer and closer to get it working.

Reply #12 on: May 11, 2014, 06:55:02 pm

Not very good at scripting, but..

You call this

Code Snippet

Plaintext

place1 thread place_weapons("m9");

But the function is this

Code Snippet

Plaintext

place_weapons(weap)

Shouldn't it be

Code Snippet

Plaintext

place1 thread place_weapons(weap);

because it switches to the m9 inside of the function itself?

Last Edit: May 11, 2014, 06:56:31 pm by mrpeanut188

Reply #13 on: May 11, 2014, 07:23:54 pm

Ege115
Community Scripter
517 Posts
161 Respect +1

Quote from: mrpeanut188 on May 11, 2014, 06:55:02 pm

Not very good at scripting, but..

You call this
Code Snippet
Plaintext
place1 thread place_weapons("m9");
But the function is this
Code Snippet
Plaintext
place_weapons(weap)
Shouldn't it be
Code Snippet
Plaintext
place1 thread place_weapons(weap);
because it switches to the m9 inside of the function itself?

Hmm, that can't be the issue as this script works in other cases. This time I am making it with the case statement, but it just doesn't takes the weapon.

Reply #14 on: May 11, 2014, 07:25:57 pm

PROxFTW
Community Scripter
214 Posts
82 Respect +1

Test this

Code Snippet

Plaintext

main()
{
	place1 = getEnt( "place1", "targetname" );
	place1 thread place_weapons( "m9" );
}

place_weapons( Weap )
{
	ice_model = GetEnt( "ice_model","targetname" ); 

	while( 1 )
	{
		while( isDefined( self ) )
		{
			ice_model hide();
			self waittill( "trigger", player );
 
			CurrWeap = player GetCurrentWeapon();
			if( CurrWeap == Weap )
			{
				self trigger_off();
				level.times_placed++;

				if( level.times_placed == 1 )
				{
					switch( CurrWeap )
					{
						case "m9":
							player takeweapon( CurrWeap );
							ice_model show();
							ice_model setmodel( "zombie_3rd_perk_bottle_doubletap" );
							self waittill( "trigger", player );
							player giveweapon( CurrWeap + "_upgraded" );
							ice_model hide();
							self trigger_on();
							break;

                   	    default: 
                   	    	break;
                   	}
				}            	
        	}
		}
	}
}

	Benevolent Soul who has our eternal gratitude and exclusive access to betas and the donator section of the forum.
	Has shown effort and knowledge in the area of scripting while being a part of the UGX-Mods community.

UGX-Mods Login

case statement