SP zones in Scripting

Created on: March 02, 2014, 04:55:33 am

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

I'm trying to add zones to SP but no matter what i try the game always freezes and the console gives no hint as to why. I've tried changing the code up a bit but it its always the same result.

Code:

Code Snippet

Plaintext

begin_zone_think(zone)
{
	while(1)
	{
		players = get_players();
 
		zone = getEntarray(zone, "targetname");
 
		if(players istouching(zone) )
		{
			zone.is_active = true;
		}
		else
		{
			zone.is_active = false;
		}
	}
 
	if(zone.is_active == true)
	{
		zone_spawners = getEntarray(zone.target, "targetname");

		zone_spawners dospawn();
	}
	wait(1);
}

Obviously the way the AI is spawned is stupid. It was just something i put in there to see what would happen.

Reply #1 on: March 02, 2014, 10:40:02 am

YaPh1l
Scripter Elite
277 Posts
112 Respect +1

Just looked over it quickly, you cannot call IsTouching() on an array of entities.

- Phil.

Reply #2 on: March 02, 2014, 12:05:02 pm

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

Quote from: YaPh1l on March 02, 2014, 10:40:02 am

Just looked over it quickly, you cannot call IsTouching() on an array of entities.

- Phil.

Does this look any better?

Code Snippet

Plaintext

begin_zone_think()
{
	if(!isdefined(level.zones) )
	{
		level.zones = [];
		level.zones = getEntarray("initial_zone", "targetname");
	}
	while(1)
	{
		players = get_players();

		zone = GetArrayKeys( level.zones );

		for( i=0; i<zone.size; i++ )
		{
			if(players istouching(zone[i]) )
			{
				level.zone[i].is_active = true;
				level.zone_spawners = get_zone_specific_spawners(zone[i]);
			}
			else
			{
				level.zone.is_active = false;
			}
		}
 
		wait(.5);
 
		if(isdefined(level.zone_spawners) )
		{
			level.zone_spawners.count = 9999;
			level.zone_spawners dospawn();
		}
		wait(1);
	}
}
get_Zone_specific_spawners(zone)
{	
	if(!isdefined(zone) )
	{
		zone = undefined;
	}
 
	zone_spawners = zone.target + "_spawners";

	return zone_spawners;
}

I added/changed it a bit because i had gotten it to load but it still doesn't spawn AI when a player walks into a zone.

Last Edit: March 02, 2014, 12:56:06 pm by daedra descent

Reply #3 on: March 02, 2014, 02:13:03 pm

YaPh1l
Scripter Elite
277 Posts
112 Respect +1

You are still calling IsTouching() on an array.

- Phil.

Reply #4 on: March 02, 2014, 05:06:25 pm

yaphil cant he do something like this in the for loop?

Code Snippet

Plaintext

for( i=0; i<zone.size; i++ )
        {
		    for( i=0; i<players.size; i++ )
            {
                     if(players[i] istouching(zone[i]) )
                     {
                       level.zone[i].is_active = true;
                       level.zone_spawners = get_zone_specific_spawners(zone[i]);
                     }
                     else
                     {
                       level.zone.is_active = false;
                     }
			}
        }

Reply #5 on: March 02, 2014, 05:19:26 pm

Ege115
Scripter
517 Posts
161 Respect +1

I am not the best at scripting but as for the array that wont work with istouching() don't just have to make it look like this?

Code Snippet

Plaintext

begin_zone_think(zone)
{
    while(1)
    {
        players = get_players();
        
        zone = getEnt(zone, "targetname");
        
        if(players istouching(zone) )
        {
            zone.is_active = true;
        }
        else
        {
            zone.is_active = false;
        }
    }
    
    if(zone.is_active == true)
    {
        zone_spawners = getEntarray(zone.target, "targetname");

        zone_spawners dospawn();
    }
    wait(1);
}

First there is an array entity, and it is being called by an istouching() which YaPhil says it is not working. Then if you maybe just remove the array entity at the top which I did here now and not remove the array entity at the bottom because that entity is not being called by an istouching()

Am I right about this? I don't know if this will work but I did as Phil said, removed the array.

Reply #6 on: March 02, 2014, 05:27:46 pm

YaPh1l
Scripter Elite
277 Posts
112 Respect +1

Quote from: Ege115 on March 02, 2014, 05:19:26 pm

Am I right about this? I don't know if this will work but I did as Phil said, removed the array.

I have never said one should remove the array. Also, you removed the zone array not the player array which IsTouching() is being called on.
jjbradman got the basic idea right, you have to do a for loop through the players array and test for every player entity individually. Obviously you have to change up your logic to accomodate for this. Also since you now have a for loop inside a for loop make sure to name the counting variables different in the inner loop, otherwise it won't work like you want it to.

- Phil.

Reply #7 on: March 02, 2014, 05:44:17 pm

Ege115
Scripter
517 Posts
161 Respect +1

Quote from: YaPh1l on March 02, 2014, 05:27:46 pm

I have never said one should remove the array. Also, you removed the zone array not the player array which IsTouching() is being called on.
jjbradman got the basic idea right, you have to do a for loop through the players array and test for every player entity individually. Obviously you have to change up your logic to accomodate for this. Also since you now have a for loop inside a for loop make sure to name the counting variables different in the inner loop, otherwise it won't work like you want it to.

- Phil.

I'm sorry Phil, I assumed that you mean't to remove the array. I thought you mean't the zone array itself.

Reply #8 on: March 02, 2014, 10:39:34 pm

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

Alright i removed the array on the zone variable, and added it to players so it would check for each individual player, but its still not spawning AI when i enter a zone(the ai is a spawner if it helps any).

code:

Code Snippet

Plaintext

begin_zone_think()
{
	if(!isdefined(level.zones) )
	{
		level.zones = [];
		level.zones = getEntarray("initial_zone", "targetname");
	}
	while(1)
	{
		players = get_players();

		zone = GetArrayKeys( level.zones );

		for( i=0; i<players.size; i++ )
		{

			if(players[i] istouching(zone) )
			{
				level.zone.is_active = true;
				level.zone_spawners = get_zone_specific_spawners(zone);
			}
			else
			{
				level.zone.is_active = false;
			}
		}
 
		wait(.5);
 
		if(level.zone.is_active)
		{
			level.zone_spawners.count = 9999;
			level.zone_spawners dospawn();
		}
		wait(1);
	}
}
get_Zone_specific_spawners(zone)
{	
	if(!isdefined(zone) )
	{
		zone = undefined;
	}
 
	zone_spawners = zone.target;

	return zone_spawners;
}

Reply #9 on: March 02, 2014, 10:47:10 pm

YaPh1l
Scripter Elite
277 Posts
112 Respect +1

Quote from: daedra descent on March 02, 2014, 10:39:34 pm

Alright i removed the array on the zone variable

I never said to remove any array...

- Phil.

Reply #10 on: March 02, 2014, 11:16:54 pm

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

Quote from: YaPh1l on March 02, 2014, 10:47:10 pm

I never said to remove any array...

- Phil.

I changed it so it would put all the players into an array, not the zones. since i can't use istouching(); with an array i have no use for it, right?

EDIT: Nevermind, i was just confused on what you meant.

Re-Edit: Still not working. I added a lprintln("player in zone"); and it keeps saying i'm in the zone when i'm not, it also doesn't get the spawners of a zone.

Last Edit: March 02, 2014, 11:25:30 pm by daedra descent

Reply #11 on: March 03, 2014, 01:17:39 am

YaPh1l
Scripter Elite
277 Posts
112 Respect +1

Well, how does your script look like currently?

- Phil.

Reply #12 on: March 03, 2014, 01:18:57 am

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

Code Snippet

Plaintext

begin_zone_think()
{
	if(!isdefined(level.zones) )
	{
		level.zones = [];
		level.zones = getEntarray("initial_zone", "targetname");
	}
	while(1)
	{
		players = get_players();

		zone = GetArrayKeys( level.zones );

		for( i=0; i<zone.size; i++ )
		{

			for( i=0; i<players.size; i++ )
			{

				if(players[i] istouching(zone[i]) )
				{
					level.zone[i].is_active = true;
					level.zone_spawners = get_zone_specific_spawners(zone[i]);

					iprintln("Player in zone");
				}
				else if(!players[i] istouching(zone[i]) ) 
				{
					level.zone.is_active = false;
					iprintln("player not in zone");
				}
			}
		}
 
		wait(.5);
 
		if(level.zone.volumes.is_active)
		{
			level.zone_spawners.count = 9999;
			level.zone_spawners dospawn();
			iprintln("AI spawned");
		}
		wait(1);
	}
}
get_Zone_specific_spawners(zone)
{	
	if(!isdefined(zone.volumes) )
	{
		zone = undefined;
	}
 
	zone_spawners = zone.target;

	return zone_spawners;

	iprintln("Got spawners");
}

I made it look more like JJbrad's edit and how it looks in _zombiemode_zone_manager.gsc.

EDIT: *facepalm* i forgot to change the I in the players loop. My bad. Still doesn't work though.

Last Edit: March 03, 2014, 01:34:11 am by daedra descent

Reply #13 on: March 03, 2014, 01:57:21 am

The reason it isn't working is because you have the same variable for player and zone.
But here test this for now

Code Snippet

Plaintext

begin_zone_think()
{
    if(!isdefined(level.zones) )
    {
        level.zones = [];
        level.zones = getEntarray("initial_zone", "targetname");
    }
    while(1)
    {
        players = get_players();

        zone = GetArrayKeys( level.zones );

        for( a=0; a<zone.size; a++ )
        {

            for( i=0; i<players.size; i++ )
            {

                if(players[i] istouching(zone[a]) )
                {
                    level.zone[a].is_active = true; //Unsure if '[a]' has to be there but just test it for now
                    level.zone_spawners = get_zone_specific_spawners(zone[a]);

                    iprintln("Player in zone");
                }
                else if(!players[i] istouching(zone[a]) ) 
                {
                    level.zone[a].is_active = false; //Unsure if '[a]' has to be there but just test it for now
                    iprintln("player not in zone");
                }
            }
        }
        
        wait(.5);
    
        if(level.zone.volumes.is_active)
        {
            level.zone_spawners.count = 9999;
            level.zone_spawners dospawn();
            iprintln("AI spawned");
        }
        wait(1);
    }
}
get_Zone_specific_spawners(zone)
{	
    if(!isdefined(zone.volumes) )
    {
        zone = undefined;
    }
    
    zone_spawners = zone.target;

    return zone_spawners;

    iprintln("Got spawners");
}

Reply #14 on: March 03, 2014, 01:58:51 am

daedra descent
Community Daedra
2,789 Posts
230 Respect +1

Quote from: blackbird431 on March 03, 2014, 01:57:21 am

The reason it isn't working is because you have the same variable for player and zone.
But here test this for now

Code Snippet

Plaintext

begin_zone_think()
{
    if(!isdefined(level.zones) )
    {
        level.zones = [];
        level.zones = getEntarray("initial_zone", "targetname");
    }
    while(1)
    {
        players = get_players();

        zone = GetArrayKeys( level.zones );

        for( a=0; a<zone.size; a++ )
        {

            for( i=0; i<players.size; i++ )
            {

                if(players[i] istouching(zone[a]) )
                {
                    level.zone[a].is_active = true; //Unsure if '[a]' has to be there but just test it for now
                    level.zone_spawners = get_zone_specific_spawners(zone[a]);

                    iprintln("Player in zone");
                }
                else if(!players[i] istouching(zone[a]) ) 
                {
                    level.zone[a].is_active = false; //Unsure if '[a]' has to be there but just test it for now
                    iprintln("player not in zone");
                }
            }
        }
        
        wait(.5);
    
        if(level.zone.volumes.is_active)
        {
            level.zone_spawners.count = 9999;
            level.zone_spawners dospawn();
            iprintln("AI spawned");
        }
        wait(1);
    }
}
get_Zone_specific_spawners(zone)
{	
    if(!isdefined(zone.volumes) )
    {
        zone = undefined;
    }
    
    zone_spawners = zone.target;

    return zone_spawners;

    iprintln("Got spawners");
}

Yeah i changed that right after i posted the code hence why i made the edit.

The if statement still isn't working correctly, it says i'm in the zone when i'm not.

UGX-Mods Login

SP zones