I came across a tutorial on zombiemodding that triggered fx on zombies but it seemed to be broken, a couple of years old, and had a lot of controversy over how to do it the right way in the comments so I followed npissoawsome's comments which had his version of a script (shown below). To summarize what I'm trying to do is simple, I created a trigger_multiple in front of my zombie spawns, then i created a trigger that starts the zombie rounds and activates the trigger_multiple. My problem is that the fx doesn't play on the zombie when it passes through the trigger_multiple, but it plays on me if I pass through the trigger_multiple. If Someone can please take a look at the code below and see why the zombies don't play the fx I would be grateful, plus it could be added to the tutorials if it gets solved and can finally be a resolved issue.
effect_init() { //Original script by blackwe11 //Modified by npissoawsome level waittill("start_rounds"); //EDIT THESE/////////////////////////////////////////////////////////// trig = getEnt("cell_trig", "targetname"); thread effect_think("zombie_effect_trigger", trig, undefined); // thread effect_loader("targetname of trigger, you need to have this", "targetname of activating trigger, undefined if no trigger", "1 = needs power, undefined = doesn't need power");
Thats a lot of code for something simple like spawning an FX on an AI origin, lol.
I'm not 100% sure, but your playfxontag(); has "player" as a variable that your passing through, AND the script doesn't even get an Array of the Axis AI in the map to spawn the FX on, which leads me to believe that this script wasn't intended for AI to begin with.
I created a function that (from what i can tell) does what you want. I never tested it, but it should work.
while(1) { for( i = 0; i < triggers; i++ ) { if(players istouching(triggers[i]) && AI istouching(triggers[i]) ) // make sure that both Players and AI are in the trigs before playing the FX { playfx("CHANGE_THIS", AI.origin); } } } }
Last Edit: February 06, 2014, 03:34:44 pm by daedra descent
@daedra descent Your script won't even compile. Sorry.
@whippytrout You probably forgot to check AI_AXIS on your trigger_multiple. Depending on what you want, you might also want to check NOTPLAYER. Also, that script does damage to the triggering zombie / player (but the code is wrong, so it actually doesn't). I don't know if you want that or not. Lastly, if you use the script_flag = looping KVP, it will wait till the zombie / player is dead and not react to other zombies / players meanwhile. Well, that's all I found looking over it quickly.
It still won't work though. You only acquire the players and AI once, then never again, so you don't take into account any disconnecting players and most importantly, all the zombies that have not spawned at the time you are calling this (which are quite a lot). Also, your loop does never wait, so the engine will terminate it or it will cause it to lock up.
Thanks for the help seems like all I have to do is check the boxes you mentioned on the trigger multiple. I'm on my phone now but I'll try it when I get to my pc. It seems that you think this script is not very practical which I noticed as well. Do you know of a better way to play the fx on the zombies that wont hurt zombies? Right now I activate a trigger and the zombies spawn and walk through the trigger multiple and catch fire. It also seems the code still runs because when I quit the game it takes about 30 seconds to end. Couldn't I just make a function that waits till the trigger is pressed to play fx on zombies joints similiar to daedra descent's code?
Well, if you remove the few lines referring to damage and not set the script_flag KVP, it basically does exactly that. Could be done more nicely for sure, but it would work. Also, script code execution does not prevent the game from exiting, scripts just get terminated, at least usually.
Ok I played around with it and checked the axis box and the noplayer box in radiant and it works as you said, only the first zombie catches on fire. So I removed the script flag: looping kvp and all the zombies catch on fire but the fire goes out after a few seconds. My new question is can i make all the zombies stay on fire all the time and I need it to only happen if I select one of my two zombie spawn/round start triggers. Right now I have two triggers and if i use one it starts the round and spawns a zombie variant but no matter which one i use it always spawns them on fire. I just want one to be on fire. In the beginning of the script I thought I set one of the triggers as the activate trigger but it must not be working. Here is the lines im referring to. Do I need to thread effect_loader like I did effect_think?
Code Snippet
Plaintext
trig = getEnt("cell_trig", "targetname"); thread effect_think("zombie_effect_trigger", trig, undefined); // thread effect_loader("targetname of trigger, you need to have this", "targetname of activating trigger, undefined if no trigger", "1 = needs power, undefined = doesn't need power");
Well, you can just not call effect_think() at all and directly call effect_loader() in the code of the one trigger. To keep the fire burning, you need an extra function which does this while(IsAlive(...)) loop, so that it can be thread-called to not block the execution of the main trigger function. Alternatively, you can use a looping FX and link tag_origin scriptmodels to the zombie and delete them once the zombie dies, basically like the eye glow code from _zombiemode_spawner. That requires more work though.
Ok I did what you said about the two triggers and it works great. I'm having a little trouble with the threading part you mentioned would fix the fire from going out. I kinda get what your saying but I'm not 100% on how to do it. I've tried many ways but they all just set the first zombie on fire. I wrote a new script to try and make this work maybe you can point out where i need to thread or if I even have it set up right.
trig thread hazmat_fx(); you "thread" it so this function keeps going while the new one runs, instead of waiting for it to finish trig2 thread cell_fx();
level.zombie_variant = 0; }
hazmat_fx() { your hazmat trigger here, deleting the other one }
cell_fx() { your other trigger here deleting the hazmat one }
and work from there... (you can "thread" a function on every zombie that plays the fx and stops when he dies the same way...)
I get what your saying but I'm still confused as to what exactly I'm trying to fix. I mean I have two triggers, each starts round 1 and each selects a different zombie variant. I have a trigger multiple that is supposed to play a fire or electricity fx on each zombie if they walk through the trigger but It only plays on the first zombie that touches it. That has something to do with what phil and you said about threading but I dont know if I'm supposed to thread before each trigger starts the round and have the actual start round code and fx code in a different function or what. I feel so close I just cant get the fx to play on every zombie. I also didnt include the first triggers code in the script above, I added it in if that helps
Last Edit: February 07, 2014, 12:49:58 am by whippytrout
while(IsAlive(player)) // Here it keep's looping on the first zombie, without the rest of the function running so it doesn't "look" for new zombs untill the first one is dead.. Thread the part that plays the fx so the other function can keep tracking the zombs.. { playfxontag(level._effect["zombie_fire"] , player, "j_spine4"); playfxontag(level._effect["zombie_fire"] , player, "j_neck");
Thank that makes sense. I set up my script to do that and I added in some print lines to see if it works and keeps looping and it does. I just dont know how to make the fx play. Its not showing up and it probably has something to do with the player variable. It gave me errors about it until I added self.player to it now it runs but no fx. here is the first part:
Code Snippet
Plaintext
...... case "fire": if(isDefined(trigger.script_flag) && trigger.script_flag == "looping") {
while(IsAlive(player)) { thread activate_fx();
wait(5); } }.......
Then I have the thread:
Code Snippet
Plaintext
activate_fx() {
if(level.zombie_variant == 1) { iPrintLn("Fire zombies activated"); // this plays over and over onscreen when zombies touch trig playfxontag(level._effect["zombie_fire"] , self.player, "j_spine4"); playfxontag(level._effect["zombie_fire"] , self.player, "j_neck"); } if(level.zombie_variant == 2) { iPrintLn("Electric zombies activated"); playfxontag(level._effect["electricity"] , self.player, "j_spine4"); playfxontag(level._effect["electricity"] , self.player, "j_neck"); }
First, you want to thread the loop too. Also, thread-call the function on the triggering entity:
Code Snippet
Plaintext
case "fire": if(isDefined(trigger.script_flag) && trigger.script_flag == "looping") { player thread activate_fx(); }
Then, in activate_fx(), put the loop and use self as the reference to the entity:
Code Snippet
Plaintext
activate_fx() {
if(level.zombie_variant == 1) { iPrintLn("Fire zombies activated"); // this plays over and over onscreen when zombies touch trig while(IsAlive(self)) { playfxontag(level._effect["zombie_fire"] , self, "j_spine4"); playfxontag(level._effect["zombie_fire"] , self, "j_neck"); wait(5); } } // same for the other variant(s) }
- Phil.
Last Edit: February 07, 2014, 10:40:04 pm by YaPh1l
Reply
whippytrout 
Apeldoorn
, but if the triggers work it's fine i guess... For the threading part: