Ive been messing around with scripting lately and decided to try something kinda easy. I know there are tuts out there for something like this but im trying to make some of my own scripts for scripting practice and to better understand scripting.   I attempted to make a script so when players are touching a trigger multiple/radius it plays a custom loop sound. This script works but I am still learning when it comes to scripting so can someone please explain to me...

1. why with my code the loop sound stops when i throw a nade or switch weapons while in the trigger multiple?

2. How can i  make this script better? I know there is a better way of doing this. If i wanted to add another sound i would have to copy the code.

main()
{	
 
 
	playsound = getEntArray( "playsound", "targetname" );
	for( i = 0; i < playsound.size; i++ )
	{
		playsound[i] thread play_loop_sound();
	}
}


play_loop_sound()
{
	while( 1 )
	{
		players = get_players();
		player_touching = false;
		for( i = 0; i < players.size; i++ )
		{
			if( players[i] isTouching( self ) )
			{
				player_touching = true;
				players[i] playLoopSound( "tzp_generator_loop" ); // name of sound
				while( player_touching )
				{
					if( !players[i] isTouching( self ) )
					{
						players[i] StopLoopSound();
						player_touching = false;
						break;
					}
					wait( 0.5 );
				}
			}
		}
		wait( 0.5 );
	}
}

I think its cause you are playing the sound from the player. You may be able to get away with playlocalsound or playsound(sound,origin), or spawn an ent, link it to player, and playloopsound from that. But I am not the export on sounds. I just try things till it works. But I do know there is a difference in behavior between those three functions.

Depending on how you resolve your sound issue, depends on the solution for your function then, but... here are a few things: (as always, a bunch of ways to do it)
 - Your method is to constantly check if the player is touching something. You could just use triggers and waittill("trigger", player); in your while loop, and not need the players for loop then.
 - player_touching isn't needed, its redundant to the check
 - Since it is thread per trigger, you don't want that while loop in the while loop, you'll want to thread another function based on an if condition. The if will be a player var prob to check if they were already touching so they don't constantly run the other function when they are touching. similar to the player_touching you used, but for the player.
(The while loop in the while loop will stop, or pause, that function per ent while the second while loop is true, that is why you want to thread another function rather than another while loop.)
 - When you make a new function, passing the player var, this:

				while( player_touching )
				{
					if( !players[i] isTouching( self ) )
					{
						players[i] StopLoopSound();
						player_touching = false;
						break;
					}
					wait( 0.5 );

will become this:

//replace that while loop with self thread TouchingMe(player);
TouchingMe(player){
        player endon("disconnect");
	while( player isTouching( self ) )
		{
			wait( 0.5 );
		}
	player StopLoopSound();
}

As far as using multiple sounds, you could add a kvp script_sound to your trig and then use that in your script instead, self.script_sound.

Of course, this all changes once you figure out your sound issue. You could always just play the sound from the trigger origin too, unless you need it to follow the player around.

+1 for you !!! thanks for explaining that, i went in and changed a few things u pointed out and i remade the script. I tried doing it several different ways but i kept having that issue with the nades. I made it so only when the player is standing in the trigger multiiple it constantly checks if the player is touching something instead of before where it was always checking. Doing that  fixed the sound shutting off issue when i use a  nade or switch weapons:). Im not sure if thats the best way but it worked nicely. 

I didnt even think of using script_sound  till u mentioned it. Scripting, one big learning process. Thanks again the help. 

Yeah hes right, buried somewhere deep in the cod code that im yet to find is a stopLoopedSound() on player ( by the sounds of it - in the grenade throw function )

this is probably used for cleaning up left over sounds, i guess they never wanted us to use "player" for sounds directly ( This is why my craftables sounds stopped working once, took me ages to work out why coz "just coz" wasnt acceptable lol )

Yeah hes right, buried somewhere deep in the cod code that im yet to find is a stopLoopedSound() on player ( by the sounds of it - in the grenade throw function )

this is probably used for cleaning up left over sounds, i guess they never wanted us to use "player" for sounds directly ( This is why my craftables sounds stopped working once, took me ages to work out why coz "just coz" wasnt acceptable lol )

i remade the script so it doesn't loop constantly anymore and to fix that issue with nades and switching weapons i...

 instead of
players playLoopSound( "tzp_generator_loop" );

 i added,
sound = spawn("script_origin", self.origin);
 mysounds(sound);

then to stop the sound,
sound StopLoopSound();

with what im trying to do thats the only way i got it to work without bugs

lol - yes thats exactly what make cents suggested lol scratch that - getting really mixed up on my posts today apparently

Make sure your deleting the ent you create after the sound is finished

I dont see why you need it to only play when your there though? Have it play constantly and reduce the radius it can be heard from

Exact same effect, youll only be able to hear it when you get close, no need for triggers or functions and can use playsoundatposition()

i remade the script so it doesn't loop constantly anymore and to fix that issue with nades and switching weapons i...

 instead of
players playLoopSound( "tzp_generator_loop" );

 i added,
sound = spawn("script_origin", self.origin);
 mysounds(sound);

then to stop the sound,
sound StopLoopSound();

with what im trying to do thats the only way i got it to work without bugs

That's good, you may want to also linkto the player but definitely delete it after you are done. Otherwise you could just use a function with a loop with PlaySoundAtPosition(sound, self.origin);