[Forum Game] Find the Error in General Discussion

Created on: December 07, 2014, 11:30:30 am

JR-Imagine
Community Scripter
369 Posts
102 Respect +1

Basically, someone posts a script with an error in it, person who manages to fix the error gets to post a new broken script. (Don't post obvious errors or it defeats the purpose of the whole game, which is to test your scripting skills.)

Before you ask, no, it won't throw an actual error ingame. It just won't "work".

Code Snippet

Plaintext

step6_death_watch()
{
	time = 5;

	self waittill( "death" );

	if( isDefined( level.ee_step6_active ) && level.ee_step6_active && self isTouching( level.ee_step6_radius ) && level.ee_step6_souls < level.ee_step6_soul_c )
	{
		org = spawn( "script_origin", self.origin );
		tag = spawn( "script_model", self.origin );
		tag setModel( "tag_origin" );
		tag enableLinkTo();
		tag linkTo( org );
		tag thread step6_fx( time );

		org moveTo( level.ee_step6_fx_goto.origin, time );
		org waittill( "movedone" );

		if( level.ee_step6_souls >= level.ee_step6_soul_c )
		{
			level.ee_step6_active = false;
			flag_set( "ee_step6" );
		}

		wait 8;

		tag delete();
		org delete();

		level.ee_step6_souls++;
	}
}

This one was something I actually did wrong when scripting for Rise V2 and took me 2 days to find what was wrong with it myself.

Triton, Lossy, Purity (some nub friends of mine) and me facepalmed (and had a giggle) after finding out what was wrong with it.

Nubs who were in chat when I was talking to Ray about this, please don't spoil it for others, ty. :3

Last Edit: December 07, 2014, 12:28:38 pm by JR-Imagine

Reply #1 on: December 07, 2014, 11:33:24 am

DarkWhiss
Donator ♥
104 Posts
6 Respect +1

WOW you are bored...

Reply #2 on: December 07, 2014, 02:27:52 pm

Centric
Donator ♥
481 Posts
58 Respect +1

maybe I should have read the whole topic before answering

Last Edit: December 07, 2014, 02:29:43 pm by Centric

Reply #3 on: December 07, 2014, 02:39:36 pm

arceus
Box Mappers Elite
605 Posts
52 Respect +1

wow its checking if a vairiable is greater than or equal to before the ++ inside of a if statment that only is true if the variable isless thenso the second it becaomes equal to itwill never get to the other if check so it wont work it should look like this:

Code Snippet

Plaintext

step6_death_watch()
{
	time = 5;

	self waittill( "death" );

	if( isDefined( level.ee_step6_active ) && level.ee_step6_active && self isTouching( level.ee_step6_radius ) && level.ee_step6_souls < level.ee_step6_soul_c )
	{
		org = spawn( "script_origin", self.origin );
		tag = spawn( "script_model", self.origin );
		tag setModel( "tag_origin" );
		tag enableLinkTo();
		tag linkTo( org );
		tag thread step6_fx( time );

		org moveTo( level.ee_step6_fx_goto.origin, time );
		org waittill( "movedone" );

                level.ee_step6_souls++;

		if( level.ee_step6_souls >= level.ee_step6_soul_c )
		{
			level.ee_step6_active = false;
			flag_set( "ee_step6" );
		}

		wait 8;

		tag delete();
		org delete();
	}
}

and yes jr i used spaces because i am lazy

now do i get to post a script

Double Post Merge: December 07, 2014, 02:47:34 pm

Code Snippet

Plaintext

charge()
{
  self endon( "grenade_fire" );
 
  time = 0;
 
  self.damage = 550;
 
  first_charge = false;
  while(1)
  {
    wait(1);
 
    if(time > 2 && first_charge == false)
    {
      self.damage = 1500;
      first_charge = true;
      break;
    }
    if(time >= 4)
    {
      self.damage = 2000;
      break;
    }
    time++;
  }
}

this one has quiet a simple error

Last Edit: December 07, 2014, 02:47:34 pm by arceus

Reply #4 on: December 07, 2014, 03:51:17 pm

DeletedUser
Deleted Member

Code Snippet

Plaintext

charge()
{
  self endon( "grenade_fire" );
 
  time = 0;
 
  self.damage = 550;
 
  first_charge = false;
  while(1)
  {
    
 
    if(time > 2 && first_charge == false)
    {
      self.damage = 1500;
      first_charge = true;
      break;
    }
    if(time >= 4)
    {
      self.damage = 2000;
      break;
    }
    time++;
    wait(1);
  }
}

Reply #5 on: December 07, 2014, 03:52:43 pm

arceus
Box Mappers Elite
605 Posts
52 Respect +1

Quote from: Ray1235 on December 07, 2014, 03:51:17 pm

Code Snippet

Plaintext

charge()
{
  self endon( "grenade_fire" );
 
  time = 0;
 
  self.damage = 550;
 
  first_charge = false;
  while(1)
  {
    
 
    if(time > 2 && first_charge == false)
    {
      self.damage = 1500;
      first_charge = true;
      break;
    }
    if(time >= 4)
    {
      self.damage = 2000;
      break;
    }
    time++;
    wait(1);
  }
}

nope

Reply #6 on: December 07, 2014, 03:59:18 pm

JR-Imagine
Community Scripter
369 Posts
102 Respect +1

Quote from: arceus on December 07, 2014, 02:39:36 pm

Code Snippet

Plaintext

step6_death_watch()
{
	time = 5;

	self waittill( "death" );

	if( isDefined( level.ee_step6_active ) && level.ee_step6_active && self isTouching( level.ee_step6_radius ) && level.ee_step6_souls < level.ee_step6_soul_c )
	{
		org = spawn( "script_origin", self.origin );
		tag = spawn( "script_model", self.origin );
		tag setModel( "tag_origin" );
		tag enableLinkTo();
		tag linkTo( org );
		tag thread step6_fx( time );

		org moveTo( level.ee_step6_fx_goto.origin, time );
		org waittill( "movedone" );

                level.ee_step6_souls++;

		if( level.ee_step6_souls >= level.ee_step6_soul_c )
		{
			level.ee_step6_active = false;
			flag_set( "ee_step6" );
		}

		wait 8;

		tag delete();
		org delete();
	}
}

and yes jr i used spaces because i am lazy

Hue, gg. Will edit when I find what's wrong with yours.

Edit:

Code Snippet

Plaintext

charge()
{
	self endon( "grenade_fire" );

	time = 0;
	self.damage = 550;
	first_charge = true;

	while(1)
	{
		wait(1);

		if( time > 2 && first_charge )
		{
			self.damage = 1500;
			first_charge = false;
			break;
		}

		if( time >= 4 )
		{
			self.damage = 2000;
			break;
		}

		time++;
	}
}

Though, could've been done simpler.

If I'm correct, someone else may post one for me.

Last Edit: December 07, 2014, 04:07:26 pm by JR-Imagine

Reply #7 on: December 07, 2014, 04:08:43 pm

arceus
Box Mappers Elite
605 Posts
52 Respect +1

Quote from: JR-Imagine on December 07, 2014, 03:59:18 pm

Edit:

Code Snippet

Plaintext

charge()
{
	self endon( "grenade_fire" );

	time = 0;
	self.damage = 550;
	first_charge = true;

	while(1)
	{
		wait(1);

		if( time > 2 && first_charge )
		{
			self.damage = 1500;
			first_charge = false;
			break;
		}

		if( time >= 4 )
		{
			self.damage = 2000;
			break;
		}

		time++;
	}
}

Though, could've been done simpler.

If I'm correct, someone else may post one for me.

stilll didnt fix the error though

Reply #8 on: December 07, 2014, 04:09:43 pm

JR-Imagine
Community Scripter
369 Posts
102 Respect +1

Wait a sec... You had a break...

Code Snippet

Plaintext

charge()
{
	self endon( "grenade_fire" );

	time = 0;
	self.damage = 550;
	first_charge = true;

	while(1)
	{
		wait(1);

		if( time > 2 && first_charge )
		{
			self.damage = 1500;
			first_charge = false;
		}

		if( time >= 4 )
		{
			self.damage = 2000;
			break;
		}

		time++;
	}
}

Also just realised I litterly just switched out true and false on first_charge, so that wouldn't make a difference.

Last Edit: December 07, 2014, 04:10:22 pm by JR-Imagine

Reply #9 on: December 07, 2014, 04:14:20 pm

arceus
Box Mappers Elite
605 Posts
52 Respect +1

Quote from: JR-Imagine on December 07, 2014, 04:09:43 pm

Wait a sec... You had a break...
Code Snippet
Plaintext
charge()
{
	self endon( "grenade_fire" );

	time = 0;
	self.damage = 550;
	first_charge = true;

	while(1)
	{
		wait(1);

		if( time > 2 && first_charge )
		{
			self.damage = 1500;
			first_charge = false;
		}

		if( time >= 4 )
		{
			self.damage = 2000;
			break;
		}

		time++;
	}
}
Also just realised I litterly just switched out true and false on first_charge, so that wouldn't make a difference.

There we go

bout time!

Reply #10 on: December 07, 2014, 04:19:24 pm

AoKMiKeY
Donator ♥
79 Posts
16 Respect +1

Code Snippet

Plaintext

thisScriptSucksBecauseOfOneErrorAndAStupidlyLongFunctionNameThatWouldStillWorkIfCompliedAndRun( smilyface )
{
	thingArray = strTok("this is an array for completly useless shit", " ");
	for( a = 0; a < thingArray.size; a ++ )
		thing[ thing.size ] = thingArray[a];

	for( b = 0; b < thing.size; b ++ )
		self iPrintLn( thing[b] );
}

/*

	resault:
	is
	an
	array 
	for
	completly
	useless
	shit

*/

really simple but only if you have had this problem before

posting for JR

Also because i was about to get it GRRRR

Reply #11 on: December 07, 2014, 04:23:38 pm

JR-Imagine
Community Scripter
369 Posts
102 Respect +1

Code Snippet

Plaintext

thisScriptSucksBecauseOfOneErrorAndAStupidlyLongFunctionNameThatWouldStillWorkIfCompliedAndRun( smilyface )
{
	thingArray = strTok("this is an array for completly useless shit", " ");
	thing = [];
 
	for( a = 0; a < thingArray.size; a ++ )
		thing[ thing.size ] = thingArray[a];

	for( b = 0; b < thing.size; b ++ )
		self iPrintLn( thing[b] );
}

I'm enjoying this.

Someone else post one cause I cba.

Last Edit: December 07, 2014, 04:49:32 pm by JR-Imagine

Reply #12 on: December 07, 2014, 04:50:46 pm

AoKMiKeY
Donator ♥
79 Posts
16 Respect +1

Putting this here

this is a mind fuck. No code should of would ever look like this but still. it does contain "3" errors. The logical process should end up printing "fuck it i give up. Logic is simple when logic is not simple". This does not happen due to a logic fail. Fix my logic and i will give you a cookie

http://pastebin.com/S4Yv5cpx >> ugx no like script indents

Code Snippet

Plaintext

thisIsSomethingFun()
{
	yes = "no";
	no = "yes";

	logicalYes = false;
	logicalFalse = true;

	if( yes != "no" )
	{
		no = "yes";
		logicalYes = true;
		logicalFalse = false;
		if( (logicalYes && !logicalFalse) && yes == no )
		{
			while( !logicalFalse )
			{
				if( logicalYes )
					logicalYes = false;
				if( logicalFalse )
					logicalFalse = false;
				logicalFalse = true;
				wait 0.05;
			}
			if( !logicalFalse )
				self iPrintLn( " logical false is set wrong " );
			else
			{
				if( logicalFalse )
					continue;

				if( no != "no" )
					continue;

				if( yes != "yes" )
					continue;

				if( logicalYes )
				{
					if( !logicalYes )
					{
						newLogical = logicalYes;
						oldLogical = newLogical;
						if( oldLogical != logicalFalse )
							nub = true;
 
						if( nub )
						{
							nub = false;
							if( !nub && (logicalYes == oldLogical))
							{
								oldLogical = no;
								if( no == "yes" )
									no = false;
								else
									no = true;
							}
							else
							{
								oldLogical = logicalFalse;
								logicalFalse = oldLogical;
								logicalYes = oldLogical;
								no = logicalFalse;
								yes = logicalYes;

								if( logicalYes )
								{
									logicalFalse = false;
									if( no != "yes" )
									{
										logicalFalse = true;
										logicalYes = false;
										if( oldLogical == logicalYes )
										{
											noLogic = true;
											self iPrintLn("fuck it i give up. Logic is simple when logic is not simple");
										}
									}
								}
							}
						}
					}
					else
						logicalYes = true;
				}
			}
		}
	}
}

Last Edit: December 07, 2014, 04:51:33 pm by aokmikey

Reply #13 on: December 07, 2014, 05:02:32 pm

arhowk
Donator ♥
39 Posts
0 Respect +1

1) "yes != "no"" will evaluate to false since yes is defined as no
2) " && yes == no" will evaluate to false
2b) idk wtf "continue" does in C#, if that was java than that would be a syntax error since theres no enclosing loop
3) if( logicalYes )
{
logicalYes is false in this scenario
4) if( logicalYes )
{
if( !logicalYes )
{
that cant happen...
5) if( !nub && (logicalYes == oldLogical))
{
that will evaluate to true and the else block which contains the print statement wont be run

Reply #14 on: December 07, 2014, 05:13:04 pm

JR-Imagine
Community Scripter
369 Posts
102 Respect +1

Code Snippet

Plaintext

thisIsSomethingFun()
{
	yes = "no";
	no = "yes";

	logicalYes = false;
	logicalFalse = true;

	if( yes != no )
	{
		no = "yes";
		logicalYes = true;
		logicalFalse = false;
		if( (logicalYes && !logicalFalse) && yes != no )
		{
			while( !logicalFalse )
			{
				if( logicalYes )
					logicalYes = false;
				if( logicalFalse )
					logicalFalse = false;
				logicalFalse = true;
				wait 0.05;
			}
			if( !logicalFalse )
				self iPrintLn( " logical false is set wrong " );
			else
			{
				// You're not in a loop, so can't use continue, commented out
				/*
				if( logicalFalse )
					continue;

				if( no != "no" )
					continue;

				if( yes != "yes" )
					continue;
				*/

				// Took out if( logicalYes )
				if( !logicalYes )
				{
					newLogical = logicalYes;
					oldLogical = newLogical;
					if( oldLogical != logicalFalse )
						nub = true;
 
					if( nub )
					{
						nub = false;
						if( !nub && (logicalYes != oldLogical))
						{
							oldLogical = no;
							if( no == "yes" )
								no = false;
							else
								no = true;
						}
						else
						{
							oldLogical = logicalFalse;
							logicalFalse = oldLogical;
							logicalYes = oldLogical;
							no = logicalFalse;
							yes = logicalYes;

							if( logicalYes )
							{
								logicalFalse = false;
								if( no != true )
								{
									logicalFalse = true;
									logicalYes = false;
									if( oldLogical != logicalYes )
									{
										noLogic = true;
										self iPrintLn("fuck it i give up. Logic is simple when logic is not simple");
									}
								}
							}
						}
					}
				}
				else
					logicalYes = true;
			}
		}
	}
}

You made my brain blow up... ;-;

New one:

Code Snippet

Plaintext

lolz()
{
	for( ; ; wait( 5 ) )
		killEveryone();
}

killEveryone( exception )
{
	players = getEntArray( "player", "classname" );
	for( i = 0; i < players.size; i++ )
	{
		if( players[i] != exception )
			players[i] doDamage( players[i].health + 666, (0,0,0) );
	}
}

Last Edit: December 07, 2014, 05:13:45 pm by JR-Imagine

UGX-Mods Login

[Forum Game] Find the Error